Skip to content

feat: add style function option to spinner #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 30, 2025
Merged

feat: add style function option to spinner #400

merged 7 commits into from
Sep 30, 2025

Conversation

@hyperz111
Copy link
Contributor

@hyperz111 hyperz111 commented Sep 25, 2025 •
edited
Loading

In this PR, i have add the styleFrame function option for spinner.

import { spinner } from '@clack/prompts';
import color from 'picocolors';

const s = spinner({
    styleFrame: color.yellow
});

s.start('Installing via npm');

setTimeout(() => {
    s.stop('Installed via npm');
}, 3000);

@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 9aad4f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clack/prompts Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 25, 2025 •
edited
Loading

@example/basic • @example/changesets

npm i https://pkg.pr.new/bombshell-dev/clack/@clack/core@400

npm i https://pkg.pr.new/bombshell-dev/clack/@clack/prompts@400

commit: 9aad4f3

@hyperz111
Copy link
Contributor Author

hyperz111 commented Sep 28, 2025 •
edited
Loading

@43081j, can you review this?

43081j
43081j reviewed Sep 29, 2025
View reviewed changes
@hyperz111 hyperz111 changed the title feat: add color option to spinner feat: add style function option to spinner Sep 29, 2025
@43081j
Copy link
Collaborator

43081j commented Sep 29, 2025

great!

can you add a changset and tests too?

we might also have to call it styleFrame to avoid it clashing with the progress bar style option 🤔

@43081j 43081j merged commit 8409f2c into bombshell-dev:main Sep 30, 2025
7 checks passed
@hyperz111 hyperz111 deleted the color-spinner branch September 30, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@43081j 43081j 43081j approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyperz111 @43081j